From: Sam Reed <reedy@users.mediawiki.org>
Date: Sun, 27 Feb 2011 00:36:10 +0000 (+0000)
Subject: $somevariable; doesn't count as defining a variable
X-Git-Tag: 1.31.0-rc.0~31739
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=1cc6c0928129483a59c5dc833f2f793db2efb96e;p=lhc%2Fweb%2Fwiklou.git

$somevariable; doesn't count as defining a variable
---

diff --git a/tests/RunSeleniumTests.php b/tests/RunSeleniumTests.php
index e9270a8909..dd97c15ed1 100644
--- a/tests/RunSeleniumTests.php
+++ b/tests/RunSeleniumTests.php
@@ -153,9 +153,9 @@ class SeleniumTester extends Maintenance {
 	public function execute() {
 		global $wgServer, $wgScriptPath, $wgHooks;
 
-		$seleniumSettings;
-		$seleniumBrowsers;
-		$seleniumTestSuites;
+		$seleniumSettings = array();
+		$seleniumBrowsers = array();
+		$seleniumTestSuites = array();
 
 		$configFile = $this->getOption( 'seleniumConfig', '' );
 		if ( strlen( $configFile ) > 0 ) {
diff --git a/tests/phpunit/includes/SeleniumConfigurationTest.php b/tests/phpunit/includes/SeleniumConfigurationTest.php
index d3b0c0f3a5..be78b507bd 100644
--- a/tests/phpunit/includes/SeleniumConfigurationTest.php
+++ b/tests/phpunit/includes/SeleniumConfigurationTest.php
@@ -121,9 +121,9 @@ testBrowser 		= "firefox"
 	 * @group SeleniumFramework
 	 */
 	public function testErrorOnIncorrectConfigFile() {
-		$seleniumSettings;
-		$seleniumBrowsers;
-		$seleniumTestSuites;
+		$seleniumSettings = array();
+		$seleniumBrowsers = array();
+		$seleniumTestSuites = array();
 
 		SeleniumConfig::getSeleniumSettings($seleniumSettings,
 			$seleniumBrowsers,
@@ -137,9 +137,9 @@ testBrowser 		= "firefox"
 	 * @group SeleniumFramework
 	 */
 	public function testErrorOnMissingConfigFile() {
-		$seleniumSettings;
-		$seleniumBrowsers;
-		$seleniumTestSuites;
+		$seleniumSettings = array();
+		$seleniumBrowsers = array();
+		$seleniumTestSuites = array();
 		global $wgSeleniumConfigFile;
 		$wgSeleniumConfigFile = '';
 		SeleniumConfig::getSeleniumSettings($seleniumSettings,
@@ -151,9 +151,9 @@ testBrowser 		= "firefox"
 	 * @group SeleniumFramework
 	 */
 	public function testUsesGlobalVarForConfigFile() {
-		$seleniumSettings;
-		$seleniumBrowsers;
-		$seleniumTestSuites;
+		$seleniumSettings = array();
+		$seleniumBrowsers = array();
+		$seleniumTestSuites = array();
 		global $wgSeleniumConfigFile;
 		$this->writeToTempFile( $this->testConfig0 );
 		$wgSeleniumConfigFile = $this->tempFileName;
@@ -177,9 +177,9 @@ testBrowser 		= "firefox"
 	 */
 	public function testgetSeleniumSettings($sampleConfig, $expectedSettings, $expectedBrowsers, $expectedSuites ) {
 		$this->writeToTempFile( $sampleConfig );
-		$seleniumSettings;
-		$seleniumBrowsers;
-		$seleniumTestSuites;
+		$seleniumSettings = array();
+		$seleniumBrowsers = array();
+		$seleniumTestSuites = array();
 
 		SeleniumConfig::getSeleniumSettings($seleniumSettings,
 			$seleniumBrowsers,