From: Brion Vibber <brion@users.mediawiki.org>
Date: Fri, 24 Nov 2006 22:11:47 +0000 (+0000)
Subject: * Use INSERT IGNORE for db-based BagOStuff add/insert, for more memcache-like
X-Git-Tag: 1.31.0-rc.0~55090
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=0a2d40dcb66644308e841f31b90b07e2d08986c8;p=lhc%2Fweb%2Fwiklou.git

* Use INSERT IGNORE for db-based BagOStuff add/insert, for more memcache-like
  behavior when keys already exist on add (instead of dying with an error...)
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 46bc64f9e7..34b9b25c31 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -215,6 +215,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Added placeholders for text injection by hooks to EditPage.php
 * (bug 8009) Automatic edit summary for redirects is not filled for edits in existing pages
 * Installer support for experimental MySQL 4.1/5.0 binary-safe schema
+* Use INSERT IGNORE for db-based BagOStuff add/insert, for more memcache-like
+  behavior when keys already exist on add (instead of dying with an error...)
 
 
 == Languages updated ==
diff --git a/includes/BagOStuff.php b/includes/BagOStuff.php
index 75951268ca..6edef87a77 100644
--- a/includes/BagOStuff.php
+++ b/includes/BagOStuff.php
@@ -390,7 +390,8 @@ class MediaWikiBagOStuff extends SqlBagOStuff {
 	}
 	function _doinsert($t, $v) {
 		$dbw =& wfGetDB( DB_MASTER );
-		return $dbw->insert($t, $v, 'MediaWikiBagOStuff::_doinsert');
+		return $dbw->insert($t, $v, 'MediaWikiBagOStuff::_doinsert',
+			array( 'IGNORE' ) );
 	}
 	function _fetchobject($result) {
 		$dbw =& wfGetDB( DB_MASTER );