From: Krinkle <krinkle@users.mediawiki.org>
Date: Sun, 8 Jan 2012 22:15:23 +0000 (+0000)
Subject: [HistoryAction] Revert r108341 as this breaks revision delete.
X-Git-Tag: 1.31.0-rc.0~25416
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=09df26371ec2c33f692eadcb9ed90a0cd0c31c0e;p=lhc%2Fweb%2Fwiklou.git

[HistoryAction] Revert r108341 as this breaks revision delete.

This construction never looked cool, but looks like this fix is not the right way, so reverting it.

This form is used for two purposes:
-- Submitting diff/oldid to (implied) action=view
-- Submitting ids-array to action=revisiondelete

That makes it complicated. Also for IE6/IE7 compatibility, there is no way to do this from the HTML itself (i.e. using <input type="submit" name="action" value="revisiondelete"> would work but leaves no option to have a custom i18n label. and <button type="submit"  name="action" value="revisiondelete">I18N LABEL</button> works but IE7 submits "I18N LABEL" as value for "action" instead of "revision delete".

Will re-fix bug 33587  in a few minutes with a "progressive-enhancement" solution from the front-end instead.
---

diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php
index 8a34aa4ced..aa1ec45c70 100644
--- a/includes/actions/HistoryAction.php
+++ b/includes/actions/HistoryAction.php
@@ -407,6 +407,7 @@ class HistoryPager extends ReverseChronologicalPager {
 		$s = Html::openElement( 'form', array( 'action' => $wgScript,
 			'id' => 'mw-history-compare' ) ) . "\n";
 		$s .= Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) . "\n";
+		$s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
 
 		$s .= '<div>' . $this->submitButton( $this->msg( 'compareselectedversions' )->text(),
 			array( 'class' => 'historysubmit' ) ) . "\n";