- do not use str_replace to replace $1 in a message. Use wfMsg

- do not use "this article" as a link text. Use the article title

diff --git a/includes/SpecialValidate.php b/includes/SpecialValidate.php
index 5f2300e..e0e72fa 100644 (file)
--- a/includes/SpecialValidate.php
+++ b/includes/SpecialValidate.php
@@ -167,7 +167,7 @@ class Validation
                                $html .= "</tr>\n" ;
                                }
                        $html .= "<tr><td {$topstyle} colspan=2></td><td {$topstyle} colspan=3><input type=checkbox name=clear_other value=1 checked>" ;
-                       $html .= str_replace ( "$1" , $article->getLocalURL() , wfMsg("val_clear_old") ) ;
+                       $html .= wfMsg ( 'val_clear_old', $skin->makeKnownLinkObj( $article ) );
                        $html .= "</td><td {$topstyle} align=right><input type=submit name=doit value='" . wfMsg("ok") . "'></td>" ;
                        $html .= "<td {$topstyle} colspan=2></td></tr></table></form>\n" ;
                        }

diff --git a/languages/Language.php b/languages/Language.php
index d0258f3..602f91a 100644 (file)
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -1258,7 +1258,7 @@ Type the name of the user in the box and press the button to make the user an ad
 'makesysop'         => 'Make a user into a sysop',
 
 # Validation
-'val_clear_old' => 'Clear my other validation data for <a href="$1">this article</a>',
+'val_clear_old' => 'Clear my other validation data for $1',
 'val_noop' => 'No opinion',
 'val_percent' => '<b>$1%</b><br>($2 of $3 points by $4 users)',
 'val_percent_single' => '<b>$1%</b><br>($2 of $3 points by one user)',