(bug 13517) list=users threw fatal error when only invalid usernames are specified

diff --git a/includes/api/ApiQueryUsers.php b/includes/api/ApiQueryUsers.php
index a24e189..80da512 100644 (file)
--- a/includes/api/ApiQueryUsers.php
+++ b/includes/api/ApiQueryUsers.php
@@ -63,11 +63,13 @@ if (!defined('MEDIAWIKI')) {
                // Canonicalize user names
                foreach($users as $u) {
                        $n = User::getCanonicalName($u);
-                       if($n === false) 
+                       if($n === false || $n === '') 
                                $retval[] = array('name' => $u, 'invalid' => '');
                         else
                                $goodNames[] = $n;
                }
+               if(empty($goodNames))
+                       return $retval;
 
                $db = $this->getDb();
                $userTable = $db->tableName('user');