(bug 27410) The tag filter on a history page should be within a <label> element....

Also remove inclusion protection for the 800th time: if a file only has classes, you don't need to do this :)

diff --git a/CREDITS b/CREDITS
index bf9faab..dfde887 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -148,6 +148,7 @@ following names for their contribution to the product.
 * Stefano Codari
 * Str4nd
 * svip
+* The Evil IP address
 * Tisane
 * Tobias Müller
 * Umherirrender

diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index e0da167..7e3b454 100644 (file)
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -145,6 +145,7 @@ production.
   unneeded CSS flipping of quickbar. Instead, introduce option 5 which sets
   left/right according to the directionality of your interface language.
 * (bug 19514) Unordered list list-style-image should be IE6-compatible (8-bit)
+* (bug 27410) The tag filter on a history page is now within a <label> element
 
 === API changes in 1.19 ===
 * BREAKING CHANGE: action=watch now requires POST and token.

diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index 76662da..6c8f4cb 100644 (file)
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -1,8 +1,5 @@
 <?php
 
-if( !defined( 'MEDIAWIKI' ) )
-       die;
-
 class ChangeTags {
        static function formatSummaryRow( $tags, $page ) {
                if( !$tags )
@@ -165,7 +162,8 @@ class ChangeTags {
                if ( !$wgUseTagFilter || !count( self::listDefinedTags() ) )
                        return $fullForm ? '' : array();
 
-               $data = array( wfMsgExt( 'tag-filter', 'parseinline' ), Xml::input( 'tagfilter', 20, $selected ) );
+               $data = array( Xml::label( wfMsgExt( 'tag-filter', 'parseinline' ), 'tagfilter' ),
+                       Xml::input( 'tagfilter', 20, $selected ) );
 
                if ( !$fullForm ) {
                        return $data;