Looks like this is not over yet. Silently log failures to a 'logging' debug log

diff --git a/includes/LogPage.php b/includes/LogPage.php
index 66cb348..a90b781 100644 (file)
--- a/includes/LogPage.php
+++ b/includes/LogPage.php
@@ -73,6 +73,9 @@ class LogPage {
                $dbw->insert( 'logging', $data, $fname );
                $newId = $dbw->insertId();
 
+               if( !($dbw->affectedRows() > 0) ) {
+                       wfDebugLog( "logging", "LogPage::saveContent failed to insert row - Error {$dbw->lastErrno()}: {$dbw->lastError()}" );
+               }
                # And update recentchanges
                if( $this->updateRecentChanges ) {
                        # Don't add private logs to RC!