* Fix breakage in rcFilterByCategories when invalid titles present in DB; incorrect...

* Don't bother filtering in rcFilterByCategories if there are no categories to filter by

diff --git a/includes/SpecialRecentchanges.php b/includes/SpecialRecentchanges.php
index 4fae635..ff14b9f 100644 (file)
--- a/includes/SpecialRecentchanges.php
+++ b/includes/SpecialRecentchanges.php
@@ -267,6 +267,10 @@ function wfSpecialRecentchanges( $par, $specialPage ) {
 }
 
 function rcFilterByCategories ( &$rows , $categories , $any ) {
+       if( empty( $categories ) ) {
+               return;
+       }
+       
        # Filter categories
        $cats = array () ;
        foreach ( $categories AS $cat ) {
@@ -279,7 +283,7 @@ function rcFilterByCategories ( &$rows , $categories , $any ) {
        $articles = array () ;
        $a2r = array () ;
        foreach ( $rows AS $k => $r ) {
-               $nt = Title::newFromText ( $r->rc_title , $r->rc_namespace ) ;
+               $nt = Title::makeTitle( $r->rc_title , $r->rc_namespace );
                $id = $nt->getArticleID() ;
                if ( $id == 0 ) continue ; # Page might have been deleted...
                if ( !in_array ( $id , $articles ) ) {