Declare visibility on class properties of RedirectSpecialPage
authorSiebrand Mazeland <siebrand@kitano.nl>
Sat, 22 Mar 2014 22:11:08 +0000 (23:11 +0100)
committerChad <chadh@wikimedia.org>
Wed, 26 Mar 2014 17:14:08 +0000 (17:14 +0000)
Change-Id: I54c0300af1ff62be7cc5a9519e97b7f825ddf09c

includes/specialpage/RedirectSpecialPage.php

index ee338d4..3fbb0e5 100644 (file)
@@ -92,8 +92,11 @@ abstract class RedirectSpecialPage extends UnlistedSpecialPage {
  * @ingroup SpecialPage
  */
 abstract class SpecialRedirectToSpecial extends RedirectSpecialPage {
-       // @todo FIXME: Visibility must be declared
-       var $redirName, $redirSubpage;
+       /** @var string Name of redirect target */
+       protected $redirName;
+
+       /** @var string Name of subpage of redirect target */
+       protected $redirSubpage;
 
        function __construct(
                $name, $redirName, $redirSubpage = false,