Bugs 4062, 3922 - unrecommended unicode control characters replaced with 'span dir...

diff --git a/includes/Skin.php b/includes/Skin.php
index e2b3c4f..80915a6 100644 (file)
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -428,9 +428,8 @@ END;
 
                // Use Unicode bidi embedding override characters,
                // to make sure links don't smash each other up in ugly ways.
-               // FIXME: should we use 'dir=emded' or something on links instead?
-               $embed = $wgContLang->isRTL() ? '‫' : '‪';
-               $pop = '‬';
+               $embed = "<span dir='" . ($wgContLang->isRTL() ? 'rtl' : 'ltr') . "'>";
+               $pop = '</span>';
                $t = $embed . implode ( "$pop | $embed" , $wgOut->mCategoryLinks ) . $pop;
                
                $msg = count( $wgOut->mCategoryLinks ) === 1 ? 'categories1' : 'categories';