Don't escape HTML title of Special:Contributions for newbies
authorYusuke Matsubara <whym@whym.org>
Mon, 23 Dec 2013 12:31:41 +0000 (21:31 +0900)
committerYusuke Matsubara <whym@whym.org>
Tue, 24 Dec 2013 02:45:48 +0000 (11:45 +0900)
This is a correction regarding the call of "->plain".
MediaWiki:pagetitle may contain variables (such as {{SITENAME}})
to be parsed, so it should not be treated as plain text.
MediaWiki:sp-contributions-newbies-title appears to be plain text only.

Change-Id: Ia6c0d955fb789535104956be9a00ce432aabe9e1

includes/specials/SpecialContributions.php

index 551b972..3af86f0 100644 (file)
@@ -98,10 +98,10 @@ class SpecialContributions extends SpecialPage {
                        $this->getSkin()->setRelevantUser( $userObj );
                } else {
                        $out->addSubtitle( $this->msg( 'sp-contributions-newbies-sub' ) );
-                       $out->setHTMLTitle(
-                               $this->msg( 'pagetitle', $this->msg( 'sp-contributions-newbies-title' ) )
-                                       ->inContentLanguage()->plain()
-                       );
+                       $out->setHTMLTitle( $this->msg(
+                               'pagetitle',
+                               $this->msg( 'sp-contributions-newbies-title' )->plain()
+                       )->inContentLanguage() );
                }
 
                if ( ( $ns = $request->getVal( 'namespace', null ) ) !== null && $ns !== '' ) {