Fix "installer started" detection
authorBrad Jorsch <bjorsch@wikimedia.org>
Fri, 9 Oct 2015 21:25:36 +0000 (17:25 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Fri, 9 Oct 2015 21:34:48 +0000 (17:34 -0400)
commit673c07656e6aa5cad2677d6cb56bbf3ceef6bea5
treee9f38ffd770850a305bebea51edf10bb091ba8ab
parent021ce584050862a9aea4e79379bf559e48ae78a6
Fix "installer started" detection

NoLocalSettings.php tries to detect whether the installer has been
started or not. But this detection has been broken since I4cf237d when a
change was made to stop setting the session name when NO_SESSION is
defined, causing NoLocalSettings.php to be looking at a different
session-cookie than is actually being used by the installer.

The complete fix is twofold:
* Have WebInstaller::startSession() call session_name()
* Have NoLocalSettings.php not call session_name() when PHP's
  session.auto_start configuration setting is set.

Change-Id: I618d11df902b5d1f70e175bc94137621e9195c2f
includes/NoLocalSettings.php
includes/installer/WebInstaller.php