From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Thu, 4 Jul 2019 17:38:58 +0000 (+0200)
Subject: PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout
X-Git-Tag: 1.34.0-rc.0~1168^2
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/config/%7B%24admin_url%7D?a=commitdiff_plain;h=cd8de7de779b20f0794f00954873dda0b47e6f87;p=lhc%2Fweb%2Fwiklou.git

PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout

TabPanelLayout is documented to take two parameters, $name and $config.
The $name position parameter can also be passed as a named config option
in the $config array, but doing so confuses Phan, since there's no good
way to document it. Just don't do it.

Bug: T227144
Change-Id: Ifbd776844d722d58bf9f13cacc490407320731c6
---

diff --git a/includes/specials/forms/PreferencesFormOOUI.php b/includes/specials/forms/PreferencesFormOOUI.php
index 9b86812dfa..5dae156993 100644
--- a/includes/specials/forms/PreferencesFormOOUI.php
+++ b/includes/specials/forms/PreferencesFormOOUI.php
@@ -146,9 +146,8 @@ class PreferencesFormOOUI extends OOUIHTMLForm {
 				) .
 				$this->getFooterText( $key );
 
-			$tabPanels[] = new OOUI\TabPanelLayout( [
+			$tabPanels[] = new OOUI\TabPanelLayout( 'mw-prefsection-' . $key, [
 				'classes' => [ 'mw-htmlform-autoinfuse-lazy' ],
-				'name' => 'mw-prefsection-' . $key,
 				'label' => $label,
 				'content' => new OOUI\FieldsetLayout( [
 					'classes' => [ 'mw-prefs-section-fieldset' ],