From: Timo Tijhof <krinklemail@gmail.com>
Date: Tue, 4 Apr 2017 22:20:02 +0000 (-0700)
Subject: mw.loader: Remove redundant compat code for IE <= 9
X-Git-Tag: 1.31.0-rc.0~3602^2
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=b4542d44a38734211ff9f75d10040b349bd39d07;p=lhc%2Fweb%2Fwiklou.git

mw.loader: Remove redundant compat code for IE <= 9

Follows-up 09fcee6110. Search for "Support: " in resources/src/.

* addEmbeddedCSS(): Remove IE9 compat code.
  Also remove now-unused variables.

* addLink(): Remove IE7-8 compat comment.
  Keep code as-is since properties are preferable in general.

Change-Id: I8a31ac96441ee78dfa2f4f2b49e0e91181430237
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 0daac5b6ae..0c8e8fe854 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -857,7 +857,6 @@
 				cssBuffer = '',
 				cssBufferTimer = null,
 				cssCallbacks = $.Callbacks(),
-				isIE9 = document.documentMode === 9,
 				rAF = window.requestAnimationFrame || setTimeout;
 
 			function getMarker() {
@@ -906,8 +905,6 @@
 			 * @param {Function} [callback]
 			 */
 			function addEmbeddedCSS( cssText, callback ) {
-				var $style, styleEl;
-
 				function fireCallbacks() {
 					var oldCallbacks = cssCallbacks;
 					// Reset cssCallbacks variable so it's not polluted by any calls to
@@ -950,29 +947,7 @@
 					cssBuffer = '';
 				}
 
-				// By default, always create a new <style>. Appending text to a <style> tag is
-				// is a performance anti-pattern as it requires CSS to be reparsed (T47810).
-				//
-				// Support: IE 6-9
-				// Try to re-use existing <style> tags due to the IE stylesheet limit (T33676).
-				if ( isIE9 ) {
-					$style = $( getMarker() ).prev();
-					// Verify that the element before the marker actually is a <style> tag created
-					// by mw.loader (not some other style tag, or e.g. a <meta> tag).
-					if ( $style.data( 'ResourceLoaderDynamicStyleTag' ) ) {
-						styleEl = $style[ 0 ];
-						styleEl.appendChild( document.createTextNode( cssText ) );
-						fireCallbacks();
-						return;
-					}
-					// Else: No existing tag to reuse. Continue below and create the first one.
-				}
-
-				$style = $( newStyleTag( cssText, getMarker() ) );
-
-				if ( isIE9 ) {
-					$style.data( 'ResourceLoaderDynamicStyleTag', true );
-				}
+				$( newStyleTag( cssText, getMarker() ) );
 
 				fireCallbacks();
 			}
@@ -1255,7 +1230,7 @@
 					el.media = media;
 				}
 				// If you end up here from an IE exception "SCRIPT: Invalid property value.",
-				// see #addEmbeddedCSS, T33676, and T49277 for details.
+				// see #addEmbeddedCSS, T33676, T43331, and T49277 for details.
 				el.href = url;
 
 				$( getMarker() ).before( el );
@@ -2042,10 +2017,6 @@
 						// "https://example.org/x.js", "http://example.org/x.js", "//example.org/x.js", "/x.js"
 						if ( /^(https?:)?\/?\//.test( modules ) ) {
 							if ( type === 'text/css' ) {
-								// Support: IE 7-8
-								// Use properties instead of attributes as IE throws security
-								// warnings when inserting a <link> tag with a protocol-relative
-								// URL set though attributes - when on HTTPS. See T43331.
 								l = document.createElement( 'link' );
 								l.rel = 'stylesheet';
 								l.href = modules;