From: Alex Monk <krenair@wikimedia.org>
Date: Wed, 1 Jul 2015 15:40:22 +0000 (+0100)
Subject: mw.Title: Handle empty this.title
X-Git-Tag: 1.31.0-rc.0~10836^2~1
X-Git-Url: https://git.cyclocoop.org/%27.WWW_URL.%27admin/?a=commitdiff_plain;h=120ec6bb082aab8b4eff6522309ad04652541fa3;p=lhc%2Fweb%2Fwiklou.git

mw.Title: Handle empty this.title

Otherwise we break code like this:
mw.Title.newFromText( '.foo' ).getPrefixedText()
because this.title[0] won't be set and you can't uppercase it

Bug: T104377
Change-Id: I1dae1e63e474757da725f76bced442ebd5b76c25
---

diff --git a/resources/src/mediawiki/mediawiki.Title.js b/resources/src/mediawiki/mediawiki.Title.js
index e46eca59e9..661ab7444b 100644
--- a/resources/src/mediawiki/mediawiki.Title.js
+++ b/resources/src/mediawiki/mediawiki.Title.js
@@ -782,7 +782,10 @@
 		 * @return {string}
 		 */
 		getName: function () {
-			if ( $.inArray( this.namespace, mw.config.get( 'wgCaseSensitiveNamespaces' ) ) !== -1 ) {
+			if (
+				$.inArray( this.namespace, mw.config.get( 'wgCaseSensitiveNamespaces' ) ) !== -1 ||
+				!this.title.length
+			) {
 				return this.title;
 			}
 			return this.title[0].toUpperCase() + this.title.slice( 1 );
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
index c0afe07c55..284f21af87 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
@@ -163,7 +163,7 @@
 		}
 	} );
 
-	QUnit.test( 'Basic parsing', 12, function ( assert ) {
+	QUnit.test( 'Basic parsing', 21, function ( assert ) {
 		var title;
 		title = new mw.Title( 'File:Foo_bar.JPG' );
 
@@ -181,6 +181,17 @@
 		title = new mw.Title( 'Foo#bar' );
 		assert.equal( title.getPrefixedText(), 'Foo' );
 		assert.equal( title.getFragment(), 'bar' );
+
+		title = new mw.Title( '.foo' );
+		assert.equal( title.getPrefixedText(), '.foo' );
+		assert.equal( title.getName(), '' );
+		assert.equal( title.getNameText(), '' );
+		assert.equal( title.getExtension(), 'foo' );
+		assert.equal( title.getDotExtension(), '.foo' );
+		assert.equal( title.getMain(), '.foo' );
+		assert.equal( title.getMainText(), '.foo' );
+		assert.equal( title.getPrefixedDb(), '.foo' );
+		assert.equal( title.getPrefixedText(), '.foo' );
 	} );
 
 	QUnit.test( 'Transformation', 11, function ( assert ) {