From e3e5f0771f60b9ccfa8cf428df4b7d22d560359b Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Sun, 11 Sep 2011 08:14:46 +0000 Subject: [PATCH] * Follow-up r96420: don't show e-mail links to anon users * Fix for r24612 (!) spotted while fixing the above: parenthesis arround the bitwise check are needed since ! operator has higher precedence than & --- includes/Linker.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/Linker.php b/includes/Linker.php index 3297e976e4..837def2bbd 100644 --- a/includes/Linker.php +++ b/includes/Linker.php @@ -941,8 +941,8 @@ class Linker { ) { global $wgUser, $wgDisableAnonTalk, $wgLang; $talkable = !( $wgDisableAnonTalk && 0 == $userId ); - $blockable = !$flags & self::TOOL_LINKS_NOBLOCK; - $addEmailLink = $flags & self::TOOL_LINKS_EMAIL; + $blockable = !( $flags & self::TOOL_LINKS_NOBLOCK ); + $addEmailLink = $flags & self::TOOL_LINKS_EMAIL && $userId; $items = array(); if ( $talkable ) { -- 2.20.1