From 0bf4b4ec4f93937a43816c92ae7ae4cdda8e67d9 Mon Sep 17 00:00:00 2001 From: Brian Wolff Date: Wed, 16 Apr 2014 17:45:26 -0300 Subject: [PATCH] Output info in update.php for skipped updates due to shared tables Can be kind of confusing for people to figure out why certain updates didn't happen. I just had an irc conversation with someone who didn't realize why their db wasn't fully updated. Change-Id: I56223e70bdac8baaf079c28cbb1f0e20ef0336b8 --- includes/installer/DatabaseUpdater.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php index 5223cd3319..b7a718f2bf 100644 --- a/includes/installer/DatabaseUpdater.php +++ b/includes/installer/DatabaseUpdater.php @@ -531,7 +531,12 @@ abstract class DatabaseUpdater { return true; } - return !in_array( $name, $wgSharedTables ); + if ( in_array( $name, $wgSharedTables ) ) { + $this->output( "...skipping update to shared table $name.\n" ); + return false; + } else { + return true; + } } /** -- 2.20.1