From: Chad Horohoe <demon@users.mediawiki.org>
Date: Fri, 5 Aug 2011 17:03:35 +0000 (+0000)
Subject: Reverting r84309 (New pages log doesn't remove/update item after suppression redirect... 
X-Git-Tag: 1.31.0-rc.0~28408
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=9787928b47c63e720d231bb344024bf6ec921135;p=lhc%2Fweb%2Fwiklou.git

Reverting r84309 (New pages log doesn't remove/update item after suppression redirect). Per the patch author and committer's own admission, this doesn't seem like the correct fix. I haven't dug into it deeply, but I tend to agree. Reverting to the status quo rather than have this make it into a release half-baked. Reopening bug 17463 so this can get some more discussion (also this definitely needed RELEASE-NOTES)
---

diff --git a/includes/Title.php b/includes/Title.php
index ca0838acb8..bea3c2284f 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3282,9 +3282,6 @@ class Title {
 		$oldid = $this->getArticleID();
 		$latest = $this->getLatestRevID();
 
-		$oldns = $this->getNamespace();
-		$olddbk = $this->getDBkey();
-
 		$dbw = wfGetDB( DB_MASTER );
 
 		if ( $moveOverRedirect ) {
@@ -3371,17 +3368,6 @@ class Title {
 				__METHOD__ );
 			$redirectSuppressed = false;
 		} else {
-			// Get rid of old new page entries in Special:NewPages and RC.
-			// Needs to be before $this->resetArticleID( 0 ).
-			$dbw->delete( 'recentchanges', array(
-					'rc_timestamp' => $dbw->timestamp( $this->getEarliestRevTime() ),
-					'rc_namespace' => $oldns,
-					'rc_title' => $olddbk,
-					'rc_new' => 1
-				),
-				__METHOD__
-			);
-
 			$this->resetArticleID( 0 );
 			$redirectSuppressed = true;
 		}