From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 11 Jul 2007 19:21:34 +0000 (+0000)
Subject: Fix regression from r23575 -- wl_notificationtimestamp didn't get updated anymore... 
X-Git-Tag: 1.31.0-rc.0~52132
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=8466f9561ec3b255d5b426b67a61d7ee494518e7;p=lhc%2Fweb%2Fwiklou.git

Fix regression from r23575 -- wl_notificationtimestamp didn't get updated anymore on update notification, leading to duplicate mails being sent out.
Doing a WHERE on x=NULL doesn't work; need to do 'x IS NULL' here.
Perhaps we should make the DB functions smarter to handle that case to do what we'd expect it to do (as we do turning arrays into 'IN (...)') but this'll fix it for now.
---

diff --git a/includes/UserMailer.php b/includes/UserMailer.php
index 3529c151c1..eac8727c9b 100644
--- a/includes/UserMailer.php
+++ b/includes/UserMailer.php
@@ -376,7 +376,7 @@ class EmailNotification {
 				), array( /* WHERE */
 					'wl_title' => $title->getDBkey(),
 					'wl_namespace' => $title->getNamespace(),
-					'wl_notificationtimestamp' => NULL
+					'wl_notificationtimestamp IS NULL'
 				), 'UserMailer::NotifyOnChange'
 			);
 			# FIXME what do we do on failure ?