From: Chad Horohoe <demon@users.mediawiki.org>
Date: Thu, 5 Jun 2008 04:15:10 +0000 (+0000)
Subject: (bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding the 'noratelimit... 
X-Git-Tag: 1.31.0-rc.0~47158
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=49f0b5bffa9eebd9c3253058246880a37be76da2;p=lhc%2Fweb%2Fwiklou.git

(bug 12859) Deprecate $wgRateLimitsExcludedGroups in favor of adding the 'noratelimit' user right. Doing it properly this time, so old functionality is still intact.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index f7e78c8ecf..234ce890fd 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -52,6 +52,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * $wgActiveUserEditCount sets the number of edits that must be performed over
   a certain number of days to be considered active
 * $wgActiveUserDays is that number of days
+* $wgRateLimitsExcludedGroups has been deprecated in favor of 
+  $wgGroupPermissions[]['noratelimit']. The former still works, however.
 
 === New features in 1.13 ===
 
@@ -335,6 +337,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 14386) Fix subpage namespace oddity when moving a talk page
 * (bug 11771) Signup form now not shown if in read-only mode.
 * (bug 10080) Users can now modify an existing block without unblocking first.
+* (bug 12859) $wgRateLimitsExcludedGroups has been deprecated in favor of
+  $wgGroupPermissions[]['noratelimit']. 
 
 === API changes in 1.13 ===
 
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 51a4d7d857..229f7c732b 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1140,10 +1140,12 @@ $wgGroupPermissions['sysop']['markbotedits']     = true;
 $wgGroupPermissions['sysop']['suppressredirect'] = true;
 $wgGroupPermissions['sysop']['apihighlimits']    = true;
 $wgGroupPermissions['sysop']['browsearchive']    = true;
+$wgGroupPermissions['sysop']['noratelimit']      = true;
 #$wgGroupPermissions['sysop']['mergehistory']     = true;
 
 // Permission to change users' group assignments
 $wgGroupPermissions['bureaucrat']['userrights']  = true;
+$wgGroupPermissions['bureaucrat']['noratelimit'] = true;
 // Permission to change users' groups assignments across wikis
 #$wgGroupPermissions['bureaucrat']['userrights-interwiki'] = true;
 
@@ -2848,8 +2850,14 @@ $wgRateLimitLog = null;
 
 /**
  * Array of groups which should never trigger the rate limiter
+ * 
+ * @deprecated as of 1.13.0, the preferred method is using
+ *  $wgGroupPermissions[]['noratelimit']. However, this will still
+ *  work if desired.
+ *  
+ *  $wgRateLimitsExcludedGroups = array( 'sysop', 'bureaucrat' );
  */
-$wgRateLimitsExcludedGroups = array( 'sysop', 'bureaucrat' );
+
 
 /**
  * On Special:Unusedimages, consider images "used", if they are put
diff --git a/includes/User.php b/includes/User.php
index 689857a8b9..bd1c9d90a3 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1102,7 +1102,13 @@ class User {
 	 */
 	public function isPingLimitable() {
 		global $wgRateLimitsExcludedGroups;
-		return array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) == array();
+		if ( array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) == array() || 
+			!$this->isAllowed('noratelimit') ) {
+				return true;
+			}
+		else {
+			return false;
+		}
 	}
 
 	/**