From: daniel <daniel.kinzler@wikimedia.de>
Date: Fri, 8 Jun 2012 09:45:10 +0000 (+0200)
Subject: cleanup for comments and edge cases
X-Git-Tag: 1.31.0-rc.0~22097^2^2~126
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=429ae88de2aa541584e0bf6ffe97f82f870774f6;p=lhc%2Fweb%2Fwiklou.git

cleanup for comments and edge cases
---

diff --git a/includes/Revision.php b/includes/Revision.php
index 059953a011..6861605a26 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -549,9 +549,8 @@ class Revision {
 				if ( !is_null( $this->mContent ) ) {
 					$this->mSize = $this->mContent->getSize();
 				} else {
-					#XXX: my be inconsistent with the notion of "size" use for the present content model
-					#NOTE: should never happen if we have either text or content object!
-					$this->mSize = is_null( $this->mText ) ? null : strlen( $this->mText );
+					#NOTE: this should never happen if we have either text or content object!
+					$this->mSize = null;
 				}
 			}
 
@@ -832,8 +831,9 @@ class Revision {
 	 *              to the $audience parameter
 	 * @return String
 	 * @deprecated in 1.WD, use getContent() instead
+	 * @todo: replace usage in core
 	 */
-	public function getText( $audience = self::FOR_PUBLIC, User $user = null ) { #FIXME: deprecated, replace usage! #FIXME: used a LOT!
+	public function getText( $audience = self::FOR_PUBLIC, User $user = null ) {
 		wfDeprecated( __METHOD__, '1.WD' );
 
 		$content = $this->getContent( $audience, $user );