From: Ricordisamoa <ricordisamoa@openmailbox.org>
Date: Wed, 10 Feb 2016 23:25:29 +0000 (+0100)
Subject: Stop doing $that = $this in includes/changes
X-Git-Tag: 1.31.0-rc.0~8000^2
X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=commitdiff_plain;h=02a32c1c7a662bfeb0fb385e96dc02e6a2ff1248;p=lhc%2Fweb%2Fwiklou.git

Stop doing $that = $this in includes/changes

Closures support $this as of PHP 5.4

Change-Id: I6bf728bf5c2222fd43945ec7a60a5f29efd42f0c
---

diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php
index 1741e64c19..73c7548b4c 100644
--- a/includes/changes/ChangesList.php
+++ b/includes/changes/ChangesList.php
@@ -491,10 +491,9 @@ class ChangesList extends ContextSource {
 			return '';
 		}
 		$cache = $this->watchMsgCache;
-		$that = $this;
 		return $cache->getWithSetCallback( $count, $cache::TTL_INDEFINITE,
-			function () use ( $that, $count ) {
-				return $that->msg( 'number_of_watching_users_RCview' )
+			function () use ( $count ) {
+				return $this->msg( 'number_of_watching_users_RCview' )
 					->numParams( $count )->escaped();
 			}
 		);