X-Git-Url: https://git.cyclocoop.org/%27.%24link.%27?a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Fupload%2FUploadBaseTest.php;h=a80262e932c0870752d27130bed736ea091d85a1;hb=30d58769ac54f8ef3f0c54558f43b9a73a68b37e;hp=dd68cdcab796bdc221e675ceb1c338244d93b1f5;hpb=fa32e55a7c7c133fd841f474237c6a11a1ff0588;p=lhc%2Fweb%2Fwiklou.git

diff --git a/tests/phpunit/includes/upload/UploadBaseTest.php b/tests/phpunit/includes/upload/UploadBaseTest.php
index dd68cdcab7..a80262e932 100644
--- a/tests/phpunit/includes/upload/UploadBaseTest.php
+++ b/tests/phpunit/includes/upload/UploadBaseTest.php
@@ -103,6 +103,8 @@ class UploadBaseTest extends MediaWikiTestCase {
 	}
 
 	/**
+	 * @covers UploadBase::verifyUpload
+	 *
 	 * test uploading a 100 bytes file with $wgMaxUploadSize = 100
 	 *
 	 * This method should be abstracted so we can test different settings.
@@ -126,6 +128,7 @@ class UploadBaseTest extends MediaWikiTestCase {
 	}
 
 	/**
+	 * @covers UploadBase::checkSvgScriptCallback
 	 * @dataProvider provideCheckSvgScriptCallback
 	 */
 	public function testCheckSvgScriptCallback( $svg, $wellFormed, $filterMatch, $message ) {
@@ -135,7 +138,7 @@ class UploadBaseTest extends MediaWikiTestCase {
 	}
 
 	public static function provideCheckSvgScriptCallback() {
-		// @codingStandardsIgnoreStart Generic.Files.LineLength
+		// phpcs:disable Generic.Files.LineLength
 		return [
 			// html5sec SVG vectors
 			[
@@ -508,10 +511,11 @@ class UploadBaseTest extends MediaWikiTestCase {
 				'DTD with aliased entities apos (Should be allowed)'
 			]
 		];
-		// @codingStandardsIgnoreEnd
+		// phpcs:enable
 	}
 
 	/**
+	 * @covers UploadBase::detectScriptInSvg
 	 * @dataProvider provideDetectScriptInSvg
 	 */
 	public function testDetectScriptInSvg( $svg, $expected, $message ) {
@@ -552,12 +556,13 @@ class UploadBaseTest extends MediaWikiTestCase {
 	}
 
 	/**
+	 * @covers UploadBase::checkXMLEncodingMissmatch
 	 * @dataProvider provideCheckXMLEncodingMissmatch
 	 */
 	public function testCheckXMLEncodingMissmatch( $fileContents, $evil ) {
 		$filename = $this->getNewTempFile();
 		file_put_contents( $filename, $fileContents );
-		$this->assertSame( UploadBase::checkXMLEncodingMissmatch( $filename ), $evil );
+		$this->assertSame( $evil, UploadBase::checkXMLEncodingMissmatch( $filename ) );
 	}
 
 	public function provideCheckXMLEncodingMissmatch() {