From 01d95d7bae5864d53fe43676b04d134ee94496e9 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Mon, 28 Jul 2008 10:16:12 +0000 Subject: [PATCH] No negative caching in the revision cache -- doesn't work anyway since memcached converts false to '', and so suppresses the error message on the second hit. --- includes/Revision.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/Revision.php b/includes/Revision.php index d0ccb46d75..eba7be4820 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -827,7 +827,8 @@ class Revision { $text = self::getRevisionText( $row ); - if( $wgRevisionCacheExpiry ) { + # No negative caching -- negative hits on text rows may be due to corrupted slave servers + if( $wgRevisionCacheExpiry && $text !== false ) { $wgMemc->set( $key, $text, $wgRevisionCacheExpiry ); } -- 2.20.1