From cda77ab8c4d4b721f1ed1c501eba7aebd0e830ff Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 23 Nov 2018 20:39:13 +0100 Subject: [PATCH] Remove unneeded "eslint-disable no-restricted-properties" from several files This was added in 160fc196fe43300843cc6cb68ad912051b7fb1d9 to suppress warnings about usage of jQuery utility methods. In eslint-config-wikimedia v0.9.0, the jQuery utility methods got its own warning code, and change 3e4e0a5774cb7531c8be7516e57550477489753d updated all files that use them to suppress each individual warning, but did not remove this now-unnecessary global suppression. Currently (since 6ad73362f376a0399bd1568fe7bbf40425737311), these comments are instead incorrectly suppressing warnings about usage of JavaScript methods introduced in ES6 and later. Change-Id: Ie70aeb325946c8e6b62333e1ca1515cd0f5f326b --- resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js | 1 - resources/src/mediawiki.legacy/protect.js | 1 - .../mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js | 1 - .../dm/mw.rcfilters.dm.FiltersViewModel.js | 1 - .../dm/mw.rcfilters.dm.SavedQueriesModel.js | 1 - resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js | 1 - resources/src/mediawiki.searchSuggest/searchSuggest.js | 1 - resources/src/mediawiki.special.apisandbox/apisandbox.js | 3 +-- .../src/mediawiki.widgets.datetime/DateTimeFormatter.js | 5 ++--- .../DiscordianDateTimeFormatter.js | 1 - .../ProlepticGregorianDateTimeFormatter.js | 1 - .../src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js | 1 - 12 files changed, 3 insertions(+), 15 deletions(-) diff --git a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js index 4044f95674..ebb469f4b8 100644 --- a/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js +++ b/resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ /*! * Experimental advanced wikitext parser-emitter. * See: https://www.mediawiki.org/wiki/Extension:UploadWizard/MessageParser for docs diff --git a/resources/src/mediawiki.legacy/protect.js b/resources/src/mediawiki.legacy/protect.js index 3258609b39..2da51222c6 100644 --- a/resources/src/mediawiki.legacy/protect.js +++ b/resources/src/mediawiki.legacy/protect.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { var ProtectionForm, reasonCodePointLimit = mw.config.get( 'wgCommentCodePointLimit' ), diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js index 20e37a9f1c..9264a397f8 100644 --- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js +++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** * View model for a filter group diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js index 5ba0b033b2..36575f78c0 100644 --- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js +++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** * View model for the filters selection and display diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js index 1327fd9052..b01aa7a2f8 100644 --- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js +++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** * View model for saved queries diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index e84e39616f..7565a0da68 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { var byteLength = require( 'mediawiki.String' ).byteLength; diff --git a/resources/src/mediawiki.searchSuggest/searchSuggest.js b/resources/src/mediawiki.searchSuggest/searchSuggest.js index 554aadb508..0069cf9cbc 100644 --- a/resources/src/mediawiki.searchSuggest/searchSuggest.js +++ b/resources/src/mediawiki.searchSuggest/searchSuggest.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ /*! * Add search suggestions to the search form. */ diff --git a/resources/src/mediawiki.special.apisandbox/apisandbox.js b/resources/src/mediawiki.special.apisandbox/apisandbox.js index b38fa87360..9b00ea200e 100644 --- a/resources/src/mediawiki.special.apisandbox/apisandbox.js +++ b/resources/src/mediawiki.special.apisandbox/apisandbox.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { 'use strict'; var ApiSandbox, Util, WidgetMethods, Validators, @@ -1650,7 +1649,7 @@ if ( done ) { container = Util.apiBool( p.info.deprecated ) ? that.deprecatedItemsFieldset : that.itemsFieldset; // FIXME: ES6-ism - // eslint-disable-next-line jquery/no-each-util + // eslint-disable-next-line no-restricted-properties index = container.getItems().findIndex( function ( el ) { return el.apiParamIndex !== undefined && el.apiParamIndex > p.info.index; } ); diff --git a/resources/src/mediawiki.widgets.datetime/DateTimeFormatter.js b/resources/src/mediawiki.widgets.datetime/DateTimeFormatter.js index 87e536dfa2..e8c1b9bdc3 100644 --- a/resources/src/mediawiki.widgets.datetime/DateTimeFormatter.js +++ b/resources/src/mediawiki.widgets.datetime/DateTimeFormatter.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** @@ -411,9 +410,9 @@ } } - // eslint-disable-next-line jquery/no-each-util + // eslint-disable-next-line no-restricted-properties if ( v.normalize ) { - // eslint-disable-next-line jquery/no-each-util + // eslint-disable-next-line no-restricted-properties v = v.normalize(); } re = new RegExp( '^\\s*' + v.replace( /([\\{}()|.?*+\-^$\[\]])/g, '\\$1' ), 'i' ); // eslint-disable-line no-useless-escape diff --git a/resources/src/mediawiki.widgets.datetime/DiscordianDateTimeFormatter.js b/resources/src/mediawiki.widgets.datetime/DiscordianDateTimeFormatter.js index bdea3528c5..66355760dc 100644 --- a/resources/src/mediawiki.widgets.datetime/DiscordianDateTimeFormatter.js +++ b/resources/src/mediawiki.widgets.datetime/DiscordianDateTimeFormatter.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** diff --git a/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js b/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js index 54524e4388..aaf8817d7e 100644 --- a/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js +++ b/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ ( function () { /** diff --git a/resources/src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js b/resources/src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js index 68bcd595de..ccfc726493 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js @@ -1,4 +1,3 @@ -/* eslint-disable no-restricted-properties */ /*! * MediaWiki Widgets - NamespaceInputWidget class. * -- 2.20.1