From c902f9a9e9e4d7b6bf59d9d9cb7b1709c3408b24 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Sun, 29 Jan 2012 19:05:25 +0000 Subject: [PATCH] [specials] Xml::namespaceSelector > Html::namespaceSelector * Makes front-end more reliable by not relying on Xml::namespaceSelector to use name="namespace" in it's output, which these forms where then requesting hardcoded from WebRequest * Poke r109990 --- includes/specials/SpecialAllpages.php | 5 ++++- includes/specials/SpecialRecentchanges.php | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php index 660e3beb0f..960a327a05 100644 --- a/includes/specials/SpecialAllpages.php +++ b/includes/specials/SpecialAllpages.php @@ -127,7 +127,10 @@ class SpecialAllpages extends IncludableSpecialPage { Xml::label( $this->msg( 'namespace' )->text(), 'namespace' ) . " " . - Xml::namespaceSelector( $namespace, null ) . ' ' . + Html::namespaceSelector( + array( 'selected' => $namespace ), + array( 'name' => 'namespace', 'id' => 'namespace' ) + ) . ' ' . Xml::submitButton( $this->msg( 'allpagessubmit' )->text() ) . " "; diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 067a95644f..06a8a0ce32 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -655,7 +655,10 @@ class SpecialRecentChanges extends IncludableSpecialPage { * @return String */ protected function namespaceFilterForm( FormOptions $opts ) { - $nsSelect = Xml::namespaceSelector( $opts['namespace'], '' ); + $nsSelect = Html::namespaceSelector( + array( 'selected' => $opts['namespace'], 'all' => '' ), + array( 'name' => 'namespace', 'id' => 'namespace' ) + ); $nsLabel = Xml::label( wfMsg( 'namespace' ), 'namespace' ); $invert = Xml::checkLabel( wfMsg( 'invert' ), 'invert', 'nsinvert', -- 2.20.1