From b8ddd4189b88bb2c7d187af4c437555960203997 Mon Sep 17 00:00:00 2001 From: Hashar Date: Wed, 30 Jul 2014 08:55:22 +0000 Subject: [PATCH] Revert "test: coverage for wfWikiID()" Cause unit tests to fail for some reason: 1) WfWikiId::testReturnsProperDbName Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'known_db_name' +'known_db_name-unittest_' tests/phpunit/includes/GlobalFunctions/wfWikiIDTest.php:10 tests/phpunit/MediaWikiTestCase.php:133 tests/phpunit/MediaWikiPHPUnitCommand.php:42 Thus making the regression job to complain whenever a patch is merged: https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/ This reverts commit 4f55b804f20960e039671a3dbf3f3eb4a5a4b81e. Change-Id: Ib08e40742b74be88b72af79ec4ab6d427e3b6d14 --- .../includes/GlobalFunctions/wfWikiIDTest.php | 22 ------------------- 1 file changed, 22 deletions(-) delete mode 100644 tests/phpunit/includes/GlobalFunctions/wfWikiIDTest.php diff --git a/tests/phpunit/includes/GlobalFunctions/wfWikiIDTest.php b/tests/phpunit/includes/GlobalFunctions/wfWikiIDTest.php deleted file mode 100644 index d3cba0d28c..0000000000 --- a/tests/phpunit/includes/GlobalFunctions/wfWikiIDTest.php +++ /dev/null @@ -1,22 +0,0 @@ -setMwGlobals( 'wgDBname', 'known_db_name' ); - $this->assertEquals('known_db_name', wfWikiID() ); - } - - public function testHonorsDatabasePrefix() { - $this->setMwGlobals( array( - 'wgDBname' => 'known_db_name', - 'wgDBprefix' => 'prefix', - )); - # Note: prefix is actually a suffix in wfWikiID() - $this->assertEquals('known_db_name-prefix', wfWikiID() ); - } - -} -- 2.20.1