From ae03d7a03b877c0fdf5135d0c752f14ccff8330c Mon Sep 17 00:00:00 2001 From: Max Semenik Date: Thu, 19 Aug 2010 20:06:54 +0000 Subject: [PATCH] Bug 24832: fatal in Special:ComparePages. I've just removed the diffonly URL parameter, because: (1) you can't intuitively expect which page should be rendered below a diff of two different pages; (2) diffonly was never available as a UI option, just a hacky GET parameter; (3) it didn't work anyway. This commit reverts most of r68885. --- includes/specials/SpecialComparePages.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/specials/SpecialComparePages.php b/includes/specials/SpecialComparePages.php index c16333d268..30d2de8ba2 100644 --- a/includes/specials/SpecialComparePages.php +++ b/includes/specials/SpecialComparePages.php @@ -51,7 +51,6 @@ class SpecialComparePages extends SpecialPage { $opts->add( 'rev1', '' ); $opts->add( 'rev2', '' ); $opts->add( 'action', '' ); - $opts->add( 'diffonly', '' ); // Set values $opts->fetchValuesFromRequest( $wgRequest ); @@ -99,13 +98,13 @@ class SpecialComparePages extends SpecialPage { if( $this->opts->getValue( 'rev1' ) && $this->opts->getValue( 'rev2' ) ) { $title = Title::newFromText( $this->opts->getValue( 'page2' ) ); - $de = new DifferenceEngine( $title, + $de = new DifferenceEngine( null, $this->opts->getValue( 'rev1' ), $this->opts->getValue( 'rev2' ), null, // rcid ( $this->opts->getValue( 'action' ) == 'purge' ), false ); - $de->showDiffPage( (bool)$this->opts->getValue( 'diffonly' ) ); + $de->showDiffPage( true ); } } -- 2.20.1