From a2251d34f94aaa1211fb18e099f78e9743d58215 Mon Sep 17 00:00:00 2001 From: Platonides Date: Tue, 19 Jul 2011 21:38:28 +0000 Subject: [PATCH] Follow up r91419. A boolean attribute can be both the empty string and its name [http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes] We use the later since that's what xhtml1 required [http://www.w3.org/TR/xhtml1/#h-4.5]. --- tests/phpunit/includes/HtmlTest.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/includes/HtmlTest.php b/tests/phpunit/includes/HtmlTest.php index 96bb180392..c0b48574f2 100644 --- a/tests/phpunit/includes/HtmlTest.php +++ b/tests/phpunit/includes/HtmlTest.php @@ -47,14 +47,13 @@ class HtmlTest extends MediaWikiTestCase { 'Boolean attributes do not generates output when value is null' ); - ### FIXME: maybe they should just output 'selected' $this->AssertEquals( - ' selected=""', + ' selected="selected"', Html::expandAttributes( array( 'selected'=>true ) ), 'Boolean attributes skip value output' ); $this->AssertEquals( - ' selected=""', + ' selected="selected"', Html::expandAttributes( array( 'selected' ) ), 'Boolean attributes (ex: selected) do not need a value' ); -- 2.20.1