From 8b84dcd18704721d3a96ad65184f1fc08a4e9421 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Tue, 29 Jan 2008 01:04:29 +0000 Subject: [PATCH] Apply a live hack from Wikimedia codebase: throw exception on invalid input to MessageCache::addMessages() --- includes/MessageCache.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/includes/MessageCache.php b/includes/MessageCache.php index fecaa53160..4776e85c2a 100644 --- a/includes/MessageCache.php +++ b/includes/MessageCache.php @@ -619,6 +619,9 @@ class MessageCache { */ function addMessages( $messages, $lang = 'en' ) { wfProfileIn( __METHOD__ ); + if ( !is_array( $messages ) ) { + throw new MWException( __METHOD__.': Invalid message array' ); + } if ( isset( $this->mExtensionMessages[$lang] ) ) { $this->mExtensionMessages[$lang] = $messages + $this->mExtensionMessages[$lang]; } else { -- 2.20.1