From 4ff82a335a4b11e7354101dbcd335c65c0216f26 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Wed, 13 Feb 2019 12:11:46 +0100 Subject: [PATCH] i18n: Add line-break in email notificaton for minor edits Added missing line-break in email notification specifically after page summary or immediately before $PAGEMINOREDIT (for minor edits). In addition, if the edit is not marked as a "minor edit", avoid the line break. Bug: T176595 Change-Id: I68cc249c3546eb7fed0834063f15304e3c245e55 --- includes/mail/EmailNotification.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/mail/EmailNotification.php b/includes/mail/EmailNotification.php index 4d1b855d78..987239be78 100644 --- a/includes/mail/EmailNotification.php +++ b/includes/mail/EmailNotification.php @@ -328,8 +328,9 @@ class EmailNotification { $keys['$PAGETITLE'] = $this->title->getPrefixedText(); $keys['$PAGETITLE_URL'] = $this->title->getCanonicalURL(); - $keys['$PAGEMINOREDIT'] = "\n" . ( $this->minorEdit ? - wfMessage( 'enotif_minoredit' )->inContentLanguage()->text() : '' ); + $keys['$PAGEMINOREDIT'] = $this->minorEdit ? + "\n\n" . wfMessage( 'enotif_minoredit' )->inContentLanguage()->text() : + ''; $keys['$UNWATCHURL'] = $this->title->getCanonicalURL( 'action=unwatch' ); if ( $this->editor->isAnon() ) { -- 2.20.1