From 4d4586ecbe96f3a584906e429b1bb84fcc8f9018 Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Wed, 28 Jan 2009 06:20:07 +0000
Subject: [PATCH] (bug 17186) Fixed incorrect stub link classing at user
 contribs

---
 includes/specials/SpecialContributions.php |  4 ++--
 includes/specials/SpecialPreferences.php   | 22 ++++++++++------------
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php
index df65f0c35b..477640be07 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -397,8 +397,8 @@ class ContribsPager extends ReverseChronologicalPager {
 			'tables' => $tables,
 			'fields' => array(
 				'page_namespace', 'page_title', 'page_is_new', 'page_latest', 'page_is_redirect',
-				'rev_id', 'rev_page','rev_text_id', 'rev_timestamp', 'rev_comment', 'rev_minor_edit', 
-				'rev_user', 'rev_user_text', 'rev_parent_id', 'rev_deleted'
+				'page_len','rev_id', 'rev_page', 'rev_text_id', 'rev_timestamp', 'rev_comment', 
+				'rev_minor_edit', 'rev_user', 'rev_user_text', 'rev_parent_id', 'rev_deleted'
 			),
 			'conds' => $conds,
 			'options' => array( 'USE INDEX' => array('revision' => $index) ),
diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php
index 11c450bcf0..8f6aab39ba 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -893,18 +893,16 @@ class PreferencesForm {
 				$mplink = htmlspecialchars( $mptitle->getLocalURL( "useskin=$skinkey" ) );
 				$previewlink = "(<a target='_blank' href=\"$mplink\">$previewtext</a>)";
 				$extraLinks = '';
-				if( $skinkey == $this->mSkin ) {
-					global $wgAllowUserCss, $wgAllowUserJs;
-					if( $wgAllowUserCss ) {
-						$cssPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.css' );
-						$customCSS = $sk->makeLinkObj( $cssPage, wfMsgExt('prefs-custom-css', array() ) );
-						$extraLinks .= " ($customCSS)";
-					}
-					if( $wgAllowUserJs ) {
-						$jsPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.js' );
-						$customJS = $sk->makeLinkObj( $jsPage, wfMsgHtml('prefs-custom-js') );
-						$extraLinks .= " ($customJS)";
-					}
+				global $wgAllowUserCss, $wgAllowUserJs;
+				if( $wgAllowUserCss ) {
+					$cssPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.css' );
+					$customCSS = $sk->makeLinkObj( $cssPage, wfMsgExt('prefs-custom-css', array() ) );
+					$extraLinks .= " ($customCSS)";
+				}
+				if( $wgAllowUserJs ) {
+					$jsPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.js' );
+					$customJS = $sk->makeLinkObj( $jsPage, wfMsgHtml('prefs-custom-js') );
+					$extraLinks .= " ($customJS)";
 				}
 				if( $skinkey == $wgDefaultSkin )
 					$sn .= ' (' . wfMsg( 'default' ) . ')';
-- 
2.20.1