From: Gregory Szorc <gszorc@users.mediawiki.org>
Date: Sat, 3 Feb 2007 06:52:37 +0000 (+0000)
Subject: Removed optional '?>' from end of generated config file
X-Git-Tag: 1.31.0-rc.0~54148
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=dd2741245618cb71d482b8edacb6c83738c99a24;p=lhc%2Fweb%2Fwiklou.git

Removed optional '?>' from end of generated config file
This will prevent people with poor editors (Windows) from accidentally introducing blank lines after the '?>', which we all know breaks XML output
---

diff --git a/config/index.php b/config/index.php
index 47ad78ca9c..b2165c426f 100644
--- a/config/index.php
+++ b/config/index.php
@@ -912,7 +912,7 @@ if( $conf->posted && ( 0 == count( $errs ) ) ) {
 		/* Write out the config file now that all is well */
 		print "<li style=\"list-style: none\">\n";
 		print "<p>Creating LocalSettings.php...</p>\n\n";
-		$localSettings = "<" . "?php$endl$local$endl?" . ">\r\n";
+		$localSettings = "<" . "?php$endl$local$endl\r\n";
 		// Fix up a common line-ending problem (due to CVS on Windows)
 		$localSettings = str_replace( "\r\n", "\n", $localSettings );
 		$f = fopen( "LocalSettings.php", 'xt' );