From: Matthew Flaschen <mflaschen@wikimedia.org>
Date: Fri, 10 Oct 2014 01:41:08 +0000 (-0400)
Subject: LSG: Break module list into text file for readability
X-Git-Tag: 1.31.0-rc.0~12651
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=4c098d0530d7c94bf2bc9bbf5d5ffc24f3569717;p=lhc%2Fweb%2Fwiklou.git

LSG: Break module list into text file for readability

Change-Id: I3d66bcacf99da7eecc91a421c521dc650ed9cf82
---

diff --git a/docs/kss/Makefile b/docs/kss/Makefile
index 31feec1a1c..0024d98d76 100644
--- a/docs/kss/Makefile
+++ b/docs/kss/Makefile
@@ -4,9 +4,9 @@ kss: kssnodecheck
 # Generates CSS of mediawiki.ui and mediawiki.ui.button using ResourceLoader, then applies it to the
 # KSS style guide
 	$(eval KSS_RL_TMP := $(shell mktemp /tmp/tmp.XXXXXXXXXX))
-# Keep module names in strict alphabetical order, so CSS loads in the same order as ResourceLoader's addModuleStyles does; this can affect rendering.
+	$(eval MODULE_STR := $(shell paste -sd "|"  < styleGuideModules.txt))
 # See OutputPage::makeResourceLoaderLink.
-	@curl -sG "${MEDIAWIKI_LOAD_URL}?modules=mediawiki.legacy.commonPrint|mediawiki.legacy.shared|mediawiki.ui|mediawiki.ui.anchor|mediawiki.ui.button|mediawiki.ui.checkbox|mediawiki.ui.radio|mediawiki.ui.icon|mediawiki.ui.input|mediawiki.ui.text&only=styles" > $(KSS_RL_TMP)
+	@curl -sG "${MEDIAWIKI_LOAD_URL}?modules=${MODULE_STR}&only=styles" > $(KSS_RL_TMP)
 	@node_modules/.bin/kss-node ../../resources/src/mediawiki.ui static/ --css $(KSS_RL_TMP) -t styleguide-template
 	@rm $(KSS_RL_TMP)
 
diff --git a/docs/kss/README.txt b/docs/kss/README.txt
index c383af9ea2..76cfb6279f 100644
--- a/docs/kss/README.txt
+++ b/docs/kss/README.txt
@@ -17,3 +17,5 @@ If MediaWiki is running on localhost, you can omit MEDIAWIKI_LOAD_URL.
 To rebuild without opening the web browser, run:
 
 MEDIAWIKI_LOAD_URL=mediawiki_hostname/w/load.php make
+
+When modifying styleGuideModules.txt, keep the list in strict alphabetical order (with no extra formatting), so CSS loads in the same order as ResourceLoader's addModuleStyles does; this can affect rendering.
diff --git a/docs/kss/styleGuideModules.txt b/docs/kss/styleGuideModules.txt
new file mode 100644
index 0000000000..79212c04da
--- /dev/null
+++ b/docs/kss/styleGuideModules.txt
@@ -0,0 +1,10 @@
+mediawiki.legacy.commonPrint
+mediawiki.legacy.shared
+mediawiki.ui
+mediawiki.ui.anchor
+mediawiki.ui.button
+mediawiki.ui.checkbox
+mediawiki.ui.radio
+mediawiki.ui.icon
+mediawiki.ui.input
+mediawiki.ui.text