From: Derick Alangi Date: Thu, 9 May 2019 14:56:40 +0000 (+0100) Subject: GlobalFunctions: Version for hard & soft deprecation must match X-Git-Tag: 1.34.0-rc.0~1734^2 X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=3737859a4fda007e0a245c03134741f567def620;p=lhc%2Fweb%2Fwiklou.git GlobalFunctions: Version for hard & soft deprecation must match Per the deprecation policy, hard and soft deprecation version for MW must match, so hard must match soft, in that order. The method wfGetLBFactory() was soft deprecated in 1.27 so hard deprecation version should be 1.27 and not 1.34 This is a follow up for 91a3f56. Change-Id: I2b4b4c97dca3bc8ecadf7a53d68ea183b4a0de9c --- diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 66a4d9a34f..486dfe4930 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -2627,7 +2627,7 @@ function wfGetLB( $wiki = false ) { * @return \Wikimedia\Rdbms\LBFactory */ function wfGetLBFactory() { - wfDeprecated( __METHOD__, '1.34' ); + wfDeprecated( __METHOD__, '1.27' ); return MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); }