From: Kunal Mehta Date: Sat, 23 Feb 2019 01:03:01 +0000 (-0800) Subject: registration: Fix 'arbitrary ResourceLoaderModule definition' schema regex X-Git-Tag: 1.34.0-rc.0~2739 X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=291fcff08e1b773f530e4df40bc6a9f40f35aa47;p=lhc%2Fweb%2Fwiklou.git registration: Fix 'arbitrary ResourceLoaderModule definition' schema regex We want this regex to match on everything that is not the literal string 'ResourceFileModule' or 'ResourceImageModule' (actually 'ResourceLoaderWikiModule' should be in this too, but I'll fix that in a follow-up). But the current regex would not match if one of those was in a substring. The new regex should match everything that is *not* those two strings. Bug: T216861 Change-Id: I7d888adfdc67b2075028e49432710308aa0125af --- diff --git a/docs/extension.schema.v1.json b/docs/extension.schema.v1.json index f9b71fbc77..2174ddb3b5 100644 --- a/docs/extension.schema.v1.json +++ b/docs/extension.schema.v1.json @@ -347,7 +347,7 @@ "properties": { "class": { "type": "string", - "pattern": "^((?!ResourceLoader(File|Image)Module).)*$" + "pattern": "^(?!ResourceLoader(File|Image)Module).*$" } }, "required": ["class"] diff --git a/docs/extension.schema.v2.json b/docs/extension.schema.v2.json index 22edac07bc..d634f703a0 100644 --- a/docs/extension.schema.v2.json +++ b/docs/extension.schema.v2.json @@ -356,7 +356,7 @@ "properties": { "class": { "type": "string", - "pattern": "^((?!ResourceLoader(File|Image)Module).)*$" + "pattern": "^(?!ResourceLoader(File|Image)Module).*$" } }, "required": ["class"]