From: Gergő Tisza <tgr.huwiki@gmail.com>
Date: Fri, 16 Aug 2019 12:06:10 +0000 (+0200)
Subject: Fix IDatabase::affectedRows() documentation
X-Git-Tag: 1.34.0-rc.0~695^2
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=211289467c7a61fadc5c6d508bfa7c041dd99489;p=lhc%2Fweb%2Fwiklou.git

Fix IDatabase::affectedRows() documentation

Bug: T229456
Change-Id: I992e81e5dbcd9db74644b2990044cf685567db5a
---

diff --git a/includes/libs/rdbms/database/IDatabase.php b/includes/libs/rdbms/database/IDatabase.php
index 6b028679ee..11a55952e8 100644
--- a/includes/libs/rdbms/database/IDatabase.php
+++ b/includes/libs/rdbms/database/IDatabase.php
@@ -452,8 +452,10 @@ interface IDatabase {
 	public function lastError();
 
 	/**
-	 * Get the number of rows affected by the last write query
-	 * @see https://www.php.net/mysql_affected_rows
+	 * Get the number of rows affected by the last write query.
+	 * Similar to https://www.php.net/mysql_affected_rows but includes rows matched
+	 * but not changed (ie. an UPDATE which sets all fields to the same value they already have).
+	 * To get the old mysql_affected_rows behavior, include non-equality of the fields in WHERE.
 	 *
 	 * @return int
 	 */