Tweak transaction for bug 13039
authorAaron Schulz <aaron@users.mediawiki.org>
Fri, 12 Sep 2008 15:03:46 +0000 (15:03 +0000)
committerAaron Schulz <aaron@users.mediawiki.org>
Fri, 12 Sep 2008 15:03:46 +0000 (15:03 +0000)
includes/Article.php

index 81853f3..1735c9e 100644 (file)
@@ -1466,8 +1466,9 @@ class Article {
                        $lastRevision = 0;
                        $revisionId = 0;
 
-                       $changed = ( strcmp( $text, $oldtext ) != 0 );
+                       $dbw->begin();
 
+                       $changed = ( strcmp( $text, $oldtext ) != 0 );
                        if ( $changed ) {
                                $this->mGoodAdjustment = (int)$this->isCountable( $text )
                                  - (int)$this->isCountable( $oldtext );
@@ -1493,7 +1494,6 @@ class Article {
                                        'user_text'  => $user->getName(),
                                        ) );
 
-                               $dbw->begin();
                                $revisionId = $revision->insertOn( $dbw );
 
                                # Update page
@@ -1519,7 +1519,6 @@ class Article {
                                                }
                                        }
                                        $user->incEditCount();
-                                       $dbw->commit();
                                }
                        } else {
                                $revision = null;
@@ -1541,6 +1540,7 @@ class Article {
 
                                # Update links tables, site stats, etc.
                                $this->editUpdates( $text, $summary, $isminor, $now, $revisionId, $changed );
+                               $dbw->commit();
                        }
                } else {
                        # Create new article