Revert r37490, 37493 for now -- 'NotifyOnPageChangeComplete hook added'
authorBrion Vibber <brion@users.mediawiki.org>
Thu, 10 Jul 2008 17:02:39 +0000 (17:02 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Thu, 10 Jul 2008 17:02:39 +0000 (17:02 +0000)
The hook seems a bit odd; it triggers on some of the composes, but not all. There's another loop right after this one.
Also, there's no need to pass objects as references here.

docs/hooks.txt
includes/UserMailer.php

index b7a3dd0..bad937b 100644 (file)
@@ -869,10 +869,6 @@ $baseID: the revision ID this was based off, if any
 &$langCode: the language code to get the message for (string) - or -
   whether to use the content language (true) or site language (false) (bool)
 
-'NotifyOnPageChangeComplete': called after user email notification.
-$EmailNotification: EmailNotification object being used
-$watchingUser: user (object) to whom email was sent
-
 'OpenSearchUrls': Called when constructing the OpenSearch description XML.
 Hooks can alter or append to the array of URLs for search & suggestion formats.
 &$urls: array of associative arrays with Url element attributes
index 75a37ad..89753f2 100644 (file)
@@ -383,7 +383,6 @@ class EmailNotification {
                                                $watchingUser->isEmailConfirmed() )
                                        {
                                                $this->compose( $watchingUser );
-                                               wfRunHooks('NotifyOnPageChangeComplete', array( &$this, &$watchingUser ));
                                        }
                                }
                        }