Don't temp users with rollback links to uneditable pages
authorAaron Schulz <aaron@users.mediawiki.org>
Thu, 29 May 2008 21:14:11 +0000 (21:14 +0000)
committerAaron Schulz <aaron@users.mediawiki.org>
Thu, 29 May 2008 21:14:11 +0000 (21:14 +0000)
includes/DifferenceEngine.php

index 09f8849..e74e4c7 100644 (file)
@@ -156,7 +156,9 @@ CONTROL;
 
                $sk = $wgUser->getSkin();
 
-               if ( $this->mNewRev->isCurrent() && $wgUser->isAllowed('rollback') ) {
+               // Check if page is editable
+               $editable = $this->mNewRev->getTitle()->userCan( 'edit' );
+               if ( $editable && $this->mNewRev->isCurrent() && $wgUser->isAllowed('rollback') ) {
                        $rollback = '&nbsp;&nbsp;&nbsp;' . $sk->generateRollback( $this->mNewRev );
                } else {
                        $rollback = '';