Clarify the $section parameter a bit on Article::replaceSection() to indicate accepta...

Throw in a strval() around the param on compare so if somebody thinks "hey I'll make it a === because it's 5ns faster" again it won't break anything. :)

diff --git a/includes/Article.php b/includes/Article.php
index b6ba6a3..523f9eb 100644 (file)
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -1265,11 +1265,12 @@ class Article {
        }
 
        /**
+        * @param $section empty/null/false or a section number (0, 1, 2, T1, T2...)
         * @return string Complete article text, or null if error
         */
        public function replaceSection( $section, $text, $summary = '', $edittime = NULL ) {
                wfProfileIn( __METHOD__ );
-               if( $section == '' ) {
+               if( strval( $section ) == '' ) {
                        // Whole-page edit; let the whole text through
                } else {
                        if( is_null($edittime) ) {