https://api.jquery.com/deferred.catch/ Since jQuery 3
deferred.catch( fn ) is an alias to deferred.then( null, fn )
This improves the readability.
Change-Id: I20fa3a1ed5c959ad0639ddf0162b8837fc15c720
- .then( null, function ( code, data, result, jqXHR ) {
+ .catch( function ( code, data, result, jqXHR ) {
var deferred = $.Deferred();
if ( code !== 'http' ) {
var deferred = $.Deferred();
if ( code !== 'http' ) {
- return ( abortable = api.post( params, ajaxOptions ) ).then(
- // If no error, return to caller as-is
- null,
+ return ( abortable = api.post( params, ajaxOptions ) ).catch(
// Error handler
function ( code ) {
if ( code === 'badtoken' ) {
// Error handler
function ( code ) {
if ( code === 'badtoken' ) {
// Always resolve, never reject
function () { return $.Deferred().resolve(); }
);
// Always resolve, never reject
function () { return $.Deferred().resolve(); }
);
// We only need a callback, not any actual module. First try a single using()
// for all loading modules. If one fails, fall back to tracking each module
// separately via $.when(), this is expensive.
// We only need a callback, not any actual module. First try a single using()
// for all loading modules. If one fails, fall back to tracking each module
// separately via $.when(), this is expensive.
- loading = mw.loader.using( modules ).then( null, function () {
+ loading = mw.loader.using( modules ).catch( function () {
var all = modules.map( function ( module ) {
var all = modules.map( function ( module ) {
- return mw.loader.using( module ).then( null, function () {
+ return mw.loader.using( module ).catch( function () {
return $.Deferred().resolve();
} );
} );
return $.Deferred().resolve();
} );
} );
// Don't cache error (T67268)
return api.getToken( 'testerror' )
// Don't cache error (T67268)
return api.getToken( 'testerror' )
- .then( null, function ( err ) {
+ .catch( function ( err ) {
assert.equal( err, 'bite-me', 'Expected error' );
return api.getToken( 'testerror' );
assert.equal( err, 'bite-me', 'Expected error' );
return api.getToken( 'testerror' );