dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9853e05) | patch
Revert r44119 "Remove extract() comment"
authorBrion Vibber <brion@users.mediawiki.org>
Wed, 10 Dec 2008 19:41:20 +0000 (19:41 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Wed, 10 Dec 2008 19:41:20 +0000 (19:41 +0000)
commitcff7bfe3e85b509d2ec23218948adecc74aaa356
tree256c32b53bfa870805c0af880cac11a302a0a8f5tree | snapshot
parent9853e055ed11b4127afd988059ae49e8408380dbcommit | diff
Revert r44119 "Remove extract() comment"
extract() is pretty much the devil and shouldn't ever be used for safe, legible code because it makes it much more difficult to analyse the code -- you have to run around trying to track down the source of local variables and there's generally a lot of pain.
Removing the FIXME comment isn't a substitute for fixing it. ;)
includes/ChangesList.php diff | blob | history
Wiklou, le Wiki du Wiklou