From e2e24bf7b90c3dcaf7c343e64c0d5beb85332f13 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 5 Mar 2009 06:00:08 +0000 Subject: [PATCH] (bug 17792) Hide DELETED_USER items --- includes/specials/SpecialContributions.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index 64c65692db..c018d4bfa7 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -384,6 +384,8 @@ class ContribsPager extends ReverseChronologicalPager { list( $tables, $index, $userCond, $join_cond ) = $this->getUserCond(); $conds = array_merge( $userCond, $this->getNamespaceCond() ); + // Paranoia: avoid brute force searches (bug 17792) + $conds[] = 'rev_deleted & ' . Revision::DELETED_USER . ' = 0'; $join_cond['page'] = array( 'INNER JOIN', 'page_id=rev_page' ); $queryInfo = array( @@ -398,7 +400,8 @@ class ContribsPager extends ReverseChronologicalPager { 'join_conds' => $join_cond ); - ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'], $queryInfo['join_conds'], $this->tagFilter ); + ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'], + $queryInfo['join_conds'], $this->tagFilter ); wfRunHooks( 'ContribsPager::getQueryInfo', array( &$this, &$queryInfo ) ); return $queryInfo; -- 2.20.1