From dc57160c0d74043673e157fe8afa6a458d646680 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 28 Jul 2008 05:31:12 +0000 Subject: [PATCH] Revert r38040 "new hook, ConfirmEmailComplete" This hook is incomplete and won't work as advertised. Will fail to run when the email address is confirmed through other means, such as a password reset; also there's no corresponding hook for when the mail gets *un*confirmed, so would lead to inconsistent state. --- RELEASE-NOTES | 2 -- docs/hooks.txt | 3 --- includes/specials/SpecialConfirmemail.php | 1 - 3 files changed, 6 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 64e8aed69a..e00615746a 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -28,8 +28,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of search engine indexing on a per-article basis. -* Added ConfirmEmailComplete hook to allow extensions to perform actions - depending on if the user's email is confirmed or not * Added SpecialMovepageBeforeMove hook to allow extensions to interfere with page moves (useful for blacklist-type extensions, for example) diff --git a/docs/hooks.txt b/docs/hooks.txt index 9a342de612..cbd008c07f 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -502,9 +502,6 @@ $catpage: CategoryPage instance $unpatrolled: Whether or not we are showing unpatrolled changes. $watched: Whether or not the change is watched by the user. -'ConfirmEmailComplete': Called after a user's email has been confirmed successfully -&$user: user (object) whose email is being confirmed - 'ContribsPager::getQueryInfo': Before the contributions query is about to run &$pager: Pager object for contributions &queryInfo: The query for the contribs Pager diff --git a/includes/specials/SpecialConfirmemail.php b/includes/specials/SpecialConfirmemail.php index cf20b77e25..9075fb9573 100644 --- a/includes/specials/SpecialConfirmemail.php +++ b/includes/specials/SpecialConfirmemail.php @@ -92,7 +92,6 @@ class EmailConfirmation extends UnlistedSpecialPage { $title = SpecialPage::getTitleFor( 'Userlogin' ); $wgOut->returnToMain( true, $title ); } - wfRunHooks( 'ConfirmEmailComplete', array( &$user ) ); } else { $wgOut->addWikiMsg( 'confirmemail_invalid' ); } -- 2.20.1