From c55130118f83ea75c36910c3991a97ff40d5608a Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Tue, 24 Sep 2019 21:20:28 +0200 Subject: [PATCH] phan: Removed PhanUndeclaredTypeParameter suppression Fixed the non-namespaced WebRequest by adding a backslash Change-Id: I9f1e3e000d9a512a74f93145cd5e66b1b38ab8b2 --- includes/http/HttpRequestFactory.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/http/HttpRequestFactory.php b/includes/http/HttpRequestFactory.php index 5315cede41..84e7b739bd 100644 --- a/includes/http/HttpRequestFactory.php +++ b/includes/http/HttpRequestFactory.php @@ -59,13 +59,12 @@ class HttpRequestFactory { * - originalRequest Information about the original request (as a WebRequest object or * an associative array with 'ip' and 'userAgent'). * @codingStandardsIgnoreStart - * @phan-param array{timeout?:int|string,connectTimeout?:int|string,postData?:array,proxy?:string,noProxy?:bool,sslVerifyHost?:bool,sslVerifyCert?:bool,caInfo?:string,maxRedirects?:int,followRedirects?:bool,userAgent?:string,method?:string,logger?:\Psr\Log\LoggerInterface,username?:string,password?:string,originalRequest?:WebRequest|array{ip:string,userAgent:string}} $options + * @phan-param array{timeout?:int|string,connectTimeout?:int|string,postData?:array,proxy?:string,noProxy?:bool,sslVerifyHost?:bool,sslVerifyCert?:bool,caInfo?:string,maxRedirects?:int,followRedirects?:bool,userAgent?:string,method?:string,logger?:\Psr\Log\LoggerInterface,username?:string,password?:string,originalRequest?:\WebRequest|array{ip:string,userAgent:string}} $options * @codingStandardsIgnoreEnd * @param string $caller The method making this request, for profiling * @throws RuntimeException * @return MWHttpRequest * @see MWHttpRequest::__construct - * @suppress PhanUndeclaredTypeParameter */ public function create( $url, array $options = [], $caller = __METHOD__ ) { if ( !Http::$httpEngine ) { -- 2.20.1