From a3cc139fcff1085ca187d08156b40251d34d6718 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Fri, 29 May 2015 20:37:34 +0200 Subject: [PATCH] SpecialMediaStatistics: Protect against invalid indexes Avoids Undefined index: \d in includes/specials/SpecialMediaStatistics.php Bug: T89534 Follow-Up: Icd06d2b22b1fcb57a8849ef6dc8659b424f27fdc Change-Id: I21b0bd4329c9b6fa06526326342edddba3f250f6 --- includes/specials/SpecialMediaStatistics.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialMediaStatistics.php b/includes/specials/SpecialMediaStatistics.php index b62de5d28e..8f14a41e4f 100644 --- a/includes/specials/SpecialMediaStatistics.php +++ b/includes/specials/SpecialMediaStatistics.php @@ -111,7 +111,11 @@ class MediaStatisticsPage extends QueryPage { protected function outputResults( $out, $skin, $dbr, $res, $num, $offset ) { $prevMediaType = null; foreach ( $res as $row ) { - list( $mediaType, $mime, $totalCount, $totalBytes ) = $this->splitFakeTitle( $row->title ); + $mediaStats = $this->splitFakeTitle( $row->title ); + if ( count( $mediaStats ) < 4 ) { + continue; + } + list( $mediaType, $mime, $totalCount, $totalBytes ) = $mediaStats; if ( $prevMediaType !== $mediaType ) { if ( $prevMediaType !== null ) { // We're not at beginning, so we have to -- 2.20.1