From 9db0dde27dcb96d56a3709f9d87e3b613c10ffeb Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 23 Jul 2014 17:19:47 -0700 Subject: [PATCH] Reject cache with future MW_USER_VERSION versions * On rollback, using newer cache versions can cause issues if fields were modified or removed. Change-Id: I7be290d6f776f9234c352dd3164b8e73dad4d49e --- includes/User.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/User.php b/includes/User.php index 778e713c7d..9951595460 100644 --- a/includes/User.php +++ b/includes/User.php @@ -369,7 +369,7 @@ class User implements IDBAccessObject { // Try cache $key = wfMemcKey( 'user', 'id', $this->mId ); $data = $wgMemc->get( $key ); - if ( !is_array( $data ) || $data['mVersion'] < MW_USER_VERSION ) { + if ( !is_array( $data ) || $data['mVersion'] != MW_USER_VERSION ) { // Object is expired, load from DB $data = false; } -- 2.20.1