From 8befd5282b3fe99a6f30681d5e6dd64e87e0fe32 Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Sun, 24 Oct 2010 15:24:04 +0000 Subject: [PATCH] (bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions now appear on Special:ListGroupRights --- RELEASE-NOTES | 2 ++ includes/specials/SpecialListgrouprights.php | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 50d6c46e3a..81594ba602 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -360,6 +360,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 25462) Fix double-escaping for section edit link tooltips * action=raw was removed for Special:Statistics. This information is still available via the API +* (bug 23934) Groups defined in $wgRevokePermissions but not in + $wgGroupPermissions now appear on Special:ListGroupRights === API changes in 1.17 === * (bug 22738) Allow filtering by action type on query=logevent. diff --git a/includes/specials/SpecialListgrouprights.php b/includes/specials/SpecialListgrouprights.php index e1294a922f..072b37d45a 100644 --- a/includes/specials/SpecialListgrouprights.php +++ b/includes/specials/SpecialListgrouprights.php @@ -60,7 +60,11 @@ class SpecialListGroupRights extends SpecialPage { '' ); - foreach( $wgGroupPermissions as $group => $permissions ) { + $allGroups = array_merge( array_keys( $wgGroupPermissions ), + array_keys( $wgRevokePermissions ) ); + foreach ( $allGroups as $group ) { + $permissions = isset( $wgGroupPermissions[$group] ) ? + $wgGroupPermissions[$group] : array(); $groupname = ( $group == '*' ) ? 'all' : $group; // Replace * with a more descriptive groupname $msg = wfMsg( 'group-' . $groupname ); -- 2.20.1