From 879abd9113851227053f73c5195d226d91fc41ba Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Sun, 11 Apr 2010 13:54:22 +0000 Subject: [PATCH] Follow up r64932: Add comment on why % is escaped --- includes/media/Bitmap.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php index 9b082b2a33..f9116442fb 100644 --- a/includes/media/Bitmap.php +++ b/includes/media/Bitmap.php @@ -157,6 +157,7 @@ class BitmapHandler extends ImageHandler { // or ImageMagick may decide your ratio is wrong and slice off // a pixel. " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) . + // A % is an escape character in ImageMagick " -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) . " -depth 8 $sharpen " . wfEscapeShellArg($dstPath) . " 2>&1"; -- 2.20.1